09a3b928ab
1. AgentRepository::updateActivity() schrieb current_ticket_id ungeprueft. Eine
unbekannte Ticket-ID lief in die FOREIGN-KEY-Constraint und kam als
ungefangene PDOException samt Stacktrace und Dateipfaden beim Client an.
Jetzt wird die Existenz vorab geprueft (422). Zusaetzlich faengt
Application::handle() unerwartete Throwables ab und antwortet mit einem
generischen 500 - Details gehen nur noch ins Log.
2. Die Normalisierung der Codeberg-Label-Farbe ("#" davor) lag im
CurlCodebergClient statt im CodebergSyncService. Damit haetten andere
Client-Implementierungen unterschiedliche Farbformate ins Ticket geschrieben.
Verschoben in die Domaenenschicht, leere Farben ergeben jetzt null.
3. Config::get() griff selbst auf getenv() zurueck, wodurch ein in der Umgebung
gesetzter CODEBERG_TOKEN in eine explizit gebaute Config durchschlug - im
Testlauf landete der Token im Klartext in der PHPUnit-Ausgabe. Die Umgebung
wird jetzt ausschliesslich in fromEnvironment() eingesammelt.
Regressionstests fuer alle drei Punkte ergaenzt: 104 Tests, 181 Assertions.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
106 lines
3.5 KiB
PHP
106 lines
3.5 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace Monitor\Api\Tests\Controller;
|
|
|
|
use Monitor\Api\Controller\AgentController;
|
|
use Monitor\Api\Db\Database;
|
|
use Monitor\Api\Http\Request;
|
|
use Monitor\Api\Repository\AgentRepository;
|
|
use Monitor\Api\Repository\TicketRepository;
|
|
use PHPUnit\Framework\TestCase;
|
|
|
|
final class AgentControllerTest extends TestCase
|
|
{
|
|
private AgentController $controller;
|
|
private AgentRepository $repository;
|
|
private TicketRepository $tickets;
|
|
|
|
protected function setUp(): void
|
|
{
|
|
$db = Database::inMemory();
|
|
$this->repository = new AgentRepository($db);
|
|
$this->tickets = new TicketRepository($db);
|
|
$this->controller = new AgentController($this->repository);
|
|
}
|
|
|
|
public function testRegisterRejectsMissingDisplayName(): void
|
|
{
|
|
$response = $this->controller->register(Request::create('POST', '/api/v1/agents', body: ['role' => 'entwickler']));
|
|
|
|
self::assertSame(422, $response->status);
|
|
}
|
|
|
|
public function testRegisterRejectsUnknownRole(): void
|
|
{
|
|
$response = $this->controller->register(Request::create('POST', '/api/v1/agents', body: [
|
|
'display_name' => 'Alice', 'role' => 'ceo',
|
|
]));
|
|
|
|
self::assertSame(422, $response->status);
|
|
}
|
|
|
|
public function testRegisterReturns201WithApiKey(): void
|
|
{
|
|
$response = $this->controller->register(Request::create('POST', '/api/v1/agents', body: [
|
|
'display_name' => 'Alice', 'role' => 'entwickler',
|
|
]));
|
|
|
|
self::assertSame(201, $response->status);
|
|
self::assertArrayHasKey('api_key', $response->body());
|
|
self::assertArrayNotHasKey('api_key_hash', $response->body()['agent']);
|
|
}
|
|
|
|
public function testActivityRejectsMismatchedAgentId(): void
|
|
{
|
|
$registration = $this->repository->register('Alice', 'entwickler');
|
|
$other = $this->repository->register('Bob', 'qa');
|
|
|
|
$response = $this->controller->activity(
|
|
Request::create('POST', '/x', body: ['state' => 'working']),
|
|
['id' => (string) $other['agent']['id']],
|
|
$registration['agent']
|
|
);
|
|
|
|
self::assertSame(403, $response->status);
|
|
}
|
|
|
|
public function testActivityRejectsMissingState(): void
|
|
{
|
|
$registration = $this->repository->register('Alice', 'entwickler');
|
|
|
|
$response = $this->controller->activity(
|
|
Request::create('POST', '/x', body: []),
|
|
['id' => (string) $registration['agent']['id']],
|
|
$registration['agent']
|
|
);
|
|
|
|
self::assertSame(422, $response->status);
|
|
}
|
|
|
|
public function testActivityUpdatesOwnState(): void
|
|
{
|
|
$registration = $this->repository->register('Alice', 'entwickler');
|
|
$ticketId = (int) $this->tickets->create(['title' => 'Testticket'])['id'];
|
|
|
|
$response = $this->controller->activity(
|
|
Request::create('POST', '/x', body: ['state' => 'working', 'current_ticket' => $ticketId]),
|
|
['id' => (string) $registration['agent']['id']],
|
|
$registration['agent']
|
|
);
|
|
|
|
self::assertSame(200, $response->status);
|
|
self::assertSame('working', $response->body()['agent']['state']);
|
|
self::assertSame($ticketId, $response->body()['agent']['current_ticket_id']);
|
|
}
|
|
|
|
public function testIndexListsAgents(): void
|
|
{
|
|
$this->repository->register('Alice', 'entwickler');
|
|
|
|
$response = $this->controller->index(Request::create('GET', '/api/v1/agents'));
|
|
|
|
self::assertCount(1, $response->body()['agents']);
|
|
}
|
|
}
|