monitor/api/tests/Unit/Controller/AgentControllerTest.php
fds2610-bot 79d97985f3 OPs-Agent repariert seine Praesenz nach dem naechsten Update selbst
Der OPs-Agent war seit seiner Registrierung am 31.08. nie praesent: seine
monitor-api.conf stammt von vor Issue #75 und kennt MONITOR_AGENT_ID nicht,
report_activity() in check_fds.sh meldete deshalb stillschweigend nichts -
waehrend die Systemmeldungen mit demselben Key weiter ankamen.

- API: jeder mit X-Api-Key authentifizierte Request frischt last_seen_at auf
  (AgentRepository::touch(), Zustand/Ticket bleiben). Greift auch, wenn auf dem
  Ping-Rechner noch ein aelteres check_fds.sh liegt.
- API: neuer Endpunkt GET /api/v1/agents/me liefert den Agenten zum Key.
- check_fds.sh: fehlt MONITOR_AGENT_ID, wird sie ueber /agents/me ermittelt
  und in monitor-api.conf nachgetragen (ohne Admin-Key).

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01F5rnDxZCwLYiEVyfrAvsAA
2026-09-13 21:47:32 +02:00

159 lines
5.7 KiB
PHP

<?php
declare(strict_types=1);
namespace Monitor\Api\Tests\Controller;
use Monitor\Api\Controller\AgentController;
use Monitor\Api\Db\Database;
use Monitor\Api\Http\Request;
use Monitor\Api\Repository\AgentRepository;
use Monitor\Api\Repository\TicketRepository;
use Monitor\Api\Repository\VoiceRecordingRepository;
use PHPUnit\Framework\TestCase;
final class AgentControllerTest extends TestCase
{
private AgentController $controller;
private AgentRepository $repository;
private TicketRepository $tickets;
private VoiceRecordingRepository $recordings;
private string $recordingsStorageDir;
protected function setUp(): void
{
$db = Database::inMemory();
$this->repository = new AgentRepository($db);
$this->tickets = new TicketRepository($db);
$this->recordingsStorageDir = sys_get_temp_dir() . '/monitor-agent-controller-recordings-' . uniqid();
$this->recordings = new VoiceRecordingRepository($db, $this->recordingsStorageDir);
$this->controller = new AgentController($this->repository, $this->recordings);
}
protected function tearDown(): void
{
if (is_dir($this->recordingsStorageDir)) {
foreach (glob($this->recordingsStorageDir . '/*') ?: [] as $file) {
unlink($file);
}
rmdir($this->recordingsStorageDir);
}
}
public function testMeReturnsAuthenticatedAgentWithoutApiKeyHash(): void
{
$this->repository->register('Alice', 'entwickler');
$ops = $this->repository->register('OPs', 'ops');
$response = $this->controller->me(Request::create('GET', '/api/v1/agents/me'), $ops['agent']);
self::assertSame(200, $response->status);
self::assertSame($ops['agent']['id'], $response->body()['agent']['id']);
self::assertArrayNotHasKey('api_key_hash', $response->body()['agent']);
}
public function testRegisterRejectsMissingDisplayName(): void
{
$response = $this->controller->register(Request::create('POST', '/api/v1/agents', body: ['role' => 'entwickler']));
self::assertSame(422, $response->status);
}
public function testRegisterRejectsUnknownRole(): void
{
$response = $this->controller->register(Request::create('POST', '/api/v1/agents', body: [
'display_name' => 'Alice', 'role' => 'ceo',
]));
self::assertSame(422, $response->status);
}
public function testRegisterReturns201WithApiKey(): void
{
$response = $this->controller->register(Request::create('POST', '/api/v1/agents', body: [
'display_name' => 'Alice', 'role' => 'entwickler',
]));
self::assertSame(201, $response->status);
self::assertArrayHasKey('api_key', $response->body());
self::assertArrayNotHasKey('api_key_hash', $response->body()['agent']);
}
public function testActivityRejectsMismatchedAgentId(): void
{
$registration = $this->repository->register('Alice', 'entwickler');
$other = $this->repository->register('Bob', 'qa');
$response = $this->controller->activity(
Request::create('POST', '/x', body: ['state' => 'working']),
['id' => (string) $other['agent']['id']],
$registration['agent']
);
self::assertSame(403, $response->status);
}
public function testActivityRejectsMissingState(): void
{
$registration = $this->repository->register('Alice', 'entwickler');
$response = $this->controller->activity(
Request::create('POST', '/x', body: []),
['id' => (string) $registration['agent']['id']],
$registration['agent']
);
self::assertSame(422, $response->status);
}
public function testActivityUpdatesOwnState(): void
{
$registration = $this->repository->register('Alice', 'entwickler');
$ticketId = (int) $this->tickets->create(['title' => 'Testticket'])['id'];
$response = $this->controller->activity(
Request::create('POST', '/x', body: ['state' => 'working', 'current_ticket' => $ticketId]),
['id' => (string) $registration['agent']['id']],
$registration['agent']
);
self::assertSame(200, $response->status);
self::assertSame('working', $response->body()['agent']['state']);
self::assertSame($ticketId, $response->body()['agent']['current_ticket_id']);
}
public function testIndexListsAgents(): void
{
$this->repository->register('Alice', 'entwickler');
$response = $this->controller->index(Request::create('GET', '/api/v1/agents'));
self::assertCount(1, $response->body()['agents']);
}
/**
* Issue #85: der Zaehler auf dem Schreibtisch haengt an diesem Feld - GET /api/v1/agents
* reichert jeden Agenten um die Anzahl offener Sprachaufnahmen an.
*/
public function testIndexIncludesPendingRecordingsCount(): void
{
$registration = $this->repository->register('Alice', 'entwickler');
$agentId = (int) $registration['agent']['id'];
$done = $this->recordings->store($agentId, 'a', 'audio/webm');
$this->recordings->store($agentId, 'b', 'audio/webm');
$this->recordings->markDone((int) $done['id']);
$response = $this->controller->index(Request::create('GET', '/api/v1/agents'));
self::assertSame(1, $response->body()['agents'][0]['pending_recordings']);
}
public function testIndexDefaultsPendingRecordingsToZero(): void
{
$this->repository->register('Alice', 'entwickler');
$response = $this->controller->index(Request::create('GET', '/api/v1/agents'));
self::assertSame(0, $response->body()['agents'][0]['pending_recordings']);
}
}