09a3b928ab
1. AgentRepository::updateActivity() schrieb current_ticket_id ungeprueft. Eine
unbekannte Ticket-ID lief in die FOREIGN-KEY-Constraint und kam als
ungefangene PDOException samt Stacktrace und Dateipfaden beim Client an.
Jetzt wird die Existenz vorab geprueft (422). Zusaetzlich faengt
Application::handle() unerwartete Throwables ab und antwortet mit einem
generischen 500 - Details gehen nur noch ins Log.
2. Die Normalisierung der Codeberg-Label-Farbe ("#" davor) lag im
CurlCodebergClient statt im CodebergSyncService. Damit haetten andere
Client-Implementierungen unterschiedliche Farbformate ins Ticket geschrieben.
Verschoben in die Domaenenschicht, leere Farben ergeben jetzt null.
3. Config::get() griff selbst auf getenv() zurueck, wodurch ein in der Umgebung
gesetzter CODEBERG_TOKEN in eine explizit gebaute Config durchschlug - im
Testlauf landete der Token im Klartext in der PHPUnit-Ausgabe. Die Umgebung
wird jetzt ausschliesslich in fromEnvironment() eingesammelt.
Regressionstests fuer alle drei Punkte ergaenzt: 104 Tests, 181 Assertions.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
90 lines
3.1 KiB
PHP
90 lines
3.1 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace Monitor\Api\Tests\Sync;
|
|
|
|
use Monitor\Api\Db\Database;
|
|
use Monitor\Api\Repository\TicketRepository;
|
|
use Monitor\Api\Sync\CodebergClient;
|
|
use Monitor\Api\Sync\CodebergSyncService;
|
|
use PHPUnit\Framework\TestCase;
|
|
|
|
final class FakeCodebergClient implements CodebergClient
|
|
{
|
|
/** @param array<string, array<int, array{number:int,title:string,body:?string,labels:array}>> $issuesByState */
|
|
public function __construct(private readonly array $issuesByState)
|
|
{
|
|
}
|
|
|
|
public function listIssues(string $owner, string $repo, string $state): array
|
|
{
|
|
return $this->issuesByState[$state] ?? [];
|
|
}
|
|
}
|
|
|
|
final class CodebergSyncServiceTest extends TestCase
|
|
{
|
|
public function testSyncCreatesBacklogAndDoneTickets(): void
|
|
{
|
|
$tickets = new TicketRepository(Database::inMemory());
|
|
$client = new FakeCodebergClient([
|
|
'open' => [
|
|
['number' => 1, 'title' => 'Offenes Issue', 'body' => 'Beschreibung', 'labels' => [['name' => 'bug', 'color' => 'ff0000']]],
|
|
],
|
|
'closed' => [
|
|
['number' => 2, 'title' => 'Geschlossenes Issue', 'body' => null, 'labels' => []],
|
|
],
|
|
]);
|
|
|
|
(new CodebergSyncService($client, $tickets, 'fds2610', 'monitor'))->sync();
|
|
|
|
$backlog = $tickets->all('backlog');
|
|
$done = $tickets->all('done');
|
|
|
|
self::assertCount(1, $backlog);
|
|
self::assertSame('Offenes Issue', $backlog[0]['title']);
|
|
self::assertSame('bug', $backlog[0]['type']);
|
|
self::assertSame('#ff0000', $backlog[0]['color']);
|
|
self::assertSame('codeberg', $backlog[0]['source']);
|
|
|
|
self::assertCount(1, $done);
|
|
self::assertSame('Geschlossenes Issue', $done[0]['title']);
|
|
self::assertNull($done[0]['type']);
|
|
self::assertNull($done[0]['color']);
|
|
}
|
|
|
|
public function testSyncNormalizesLabelColorRegardlessOfLeadingHash(): void
|
|
{
|
|
$tickets = new TicketRepository(Database::inMemory());
|
|
$client = new FakeCodebergClient([
|
|
'open' => [
|
|
['number' => 1, 'title' => 'Mit Raute', 'body' => null, 'labels' => [['name' => 'bug', 'color' => '#00ff00']]],
|
|
],
|
|
'closed' => [],
|
|
]);
|
|
|
|
(new CodebergSyncService($client, $tickets, 'fds2610', 'monitor'))->sync();
|
|
|
|
self::assertSame('#00ff00', $tickets->all('backlog')[0]['color']);
|
|
}
|
|
|
|
public function testSyncDoesNotResetManuallyMovedTicket(): void
|
|
{
|
|
$tickets = new TicketRepository(Database::inMemory());
|
|
$client = new FakeCodebergClient([
|
|
'open' => [['number' => 1, 'title' => 'Issue', 'body' => null, 'labels' => []]],
|
|
'closed' => [],
|
|
]);
|
|
$service = new CodebergSyncService($client, $tickets, 'fds2610', 'monitor');
|
|
|
|
$service->sync();
|
|
$ticket = $tickets->findByExternalRef('1');
|
|
$tickets->update((int) $ticket['id'], ['column' => 'qa']);
|
|
|
|
$service->sync();
|
|
|
|
$stillQa = $tickets->findByExternalRef('1');
|
|
self::assertSame('qa', $stillQa['column_name']);
|
|
}
|
|
}
|